Although there is still a Shellcheck issue, I'm marking this as "ready" for a review, because with the upcoming Alpine changes, it probably would be good to make sure that what is marked as supported at the core matches what we're building here.

I left them out of the diff, but if this is going to land, I'd add the keychanges from #2551 and add them as a separate commit to do one big rebuild at the same time

We don't have an agreed strategy for making changes like this that affect the Dockerfiles but in themselves don't require new Docker builds.

For the @sxa key, Stuart submitted PR #2551 to change the key only (no Dockerfiles). I then did a dummy PR with updated Dockerfiles to run CI tests, which I closed unmerged after the tests were successful.

If that sounds like a good general strategy, we could maybe formalize it separately. If applied here, it would mean submitting a separate PR that only updated the Dockerfile templates and update.sh without updating any Dockerfiles. This PR would remain as a test that doesn't get merged. It's more complicated that way, but avoids the churn of PR creation when not wanted.

@nschonni

Are you intending to continue with this? I wonder if the script part is really worth the effort if it is being flagged. The architectures don't really change that much, and this is more of a one-off clean-up exercise at the moment I feel.

If you're not able to continue with the PR right now, I would submit individual PRs to drop each of the obsolete architectures, so that they could be individually reviewed.

Let me know, one way or the other!

Are you intending to continue with this? I wonder if the script part is really worth the effort if it is being flagged. The architectures don't really change that much, and this is more of a one-off clean-up exercise at the moment I feel.

Can't do a one-off cleanup, it needs to be done in the script as the permutations are at the release level inside a template.

I'll try and just suppress or address the last ShellCheck issues if there aren't any other feedback

Can't do a one-off cleanup, it needs to be done in the script as the permutations are at the release level inside a template.

Understood. I would have just wanted to wipe out the ones that aren't used at all. Your solution is finer-grained than that, I realize now.